cts/dpl: enable all test in bzl #9178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the compiler difference is resolved in The-OpenROAD-Project#9174 Signed-off-by: Matt Liberty <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly enables previously manual-only Bazel tests by removing the MANUAL_FOR_BAZEL_TESTS lists and associated tagging logic from the BUILD files for cts and dpl. The changes are straightforward, clean, and achieve the stated goal of enabling these tests for default runs, following the resolution of an underlying compiler issue. The implementation is correct and improves the maintainability of the build files by removing obsolete configurations.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the compiler difference is resolved in #9174